[PATCH] D103113: [lld-macho] Deduplicate fixed-width literals

[Thorsten via Phabricator via llvm-commits]

tschuett added a comment.

In D103113#2783198 <https://reviews.llvm.org/D103113#2783198>, @int3 wrote:

>> The hash map will have a lot of mallocs. I would expect sort + unique to be faster.
>
> I guess I could reserve() memory for the hashmap before inserting...
>
> But as the commit message notes, I'm aware this is far from an optimal implementation, and I think we can revisit this later after building out our other features. I'm mostly interested in this to see how much of a win it'll unlock when coupled with ICF.

No worries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103113/new/

https://reviews.llvm.org/D103113