[PATCH] D103113: [lld-macho] Deduplicate fixed-width literals

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 13:44:33 PDT 2021


int3 added a comment.

> The hash map will have a lot of mallocs. I would expect sort + unique to be faster.

I guess I could reserve() memory for the hashmap before inserting...

But as the commit message notes, I'm aware this is far from an optimal implementation, and I think we can revisit this later after building out our other features. I'm mostly interested in this to see how much of a win it'll unlock when coupled with ICF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103113/new/

https://reviews.llvm.org/D103113



More information about the llvm-commits mailing list