[PATCH] D103129: [llvm-reduce] Don't delete arguments of debug intrinsics

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp:47
+static bool shouldRemoveArguments(const Function &F) {
+  return !F.arg_empty() && F.getIntrinsicID() == Intrinsic::not_intrinsic;
+}
----------------
lebedev.ri wrote:
> aeubanks wrote:
> > `F.isIntrinsic()`
> While i could be okay with ignoring actual intriniscs,
> i'm not sure why we need to ignore all functions starting with `@llvm.`.
https://llvm.org/docs/LangRef.html#intrinsic-functions
`Intrinsic function names must all start with an “llvm.” prefix. This prefix is reserved in LLVM for intrinsic names; thus, function names may not begin with this prefix.`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103129/new/

https://reviews.llvm.org/D103129