[PATCH] D103126: [RISCV] Don't propagate VL/VTYPE across inline assembly in the Insert VSETVLI pass.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 16:25:42 PDT 2021


craig.topper created this revision.
craig.topper added reviewers: frasercrmck, evandro, khchen, arcbbb, HsiangKai, rogfer01.
Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, JDevlieghere, simoncook, johnrusso, rbar, asb, hiraditya.
craig.topper requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

It's conceivable someone could put a vsetvli in inline assembly
so its safer to consider them as barriers. The alternative would
be to trust that the user marks VL and VTYPE registers as clobbers
of the inline assembly if they do that, but hat seems error prone.

I'm assuming inline assembly in vector code is going to be rare.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103126

Files:
  llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
  llvm/test/CodeGen/RISCV/rvv/vsetvli-insert.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103126.347820.patch
Type: text/x-patch
Size: 7100 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210525/a1072e44/attachment-0001.bin>


More information about the llvm-commits mailing list