[PATCH] D103100: [AIX] Enable stackprotect feature

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:133
 
+const char AIXSSPCanaryWordName[] = "__ssp_canary_word";
+
----------------
Not declaring `static` explicitly means that some header somewhere declaring this as `extern` will cause this to be an external definition. I don't think that's great (and I don't think the case is strong for this file to contain a potentially-external definition of this name).


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16409
 
-// Override to disable global variable loading on Linux.
 void PPCTargetLowering::insertSSPDeclarations(Module &M) const {
----------------
Why remove the old comment? The code still does override and only use the base implementation for non-Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103100/new/

https://reviews.llvm.org/D103100