[PATCH] D103100: [AIX] Enable stackprotect feature

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a subscriber: w2yehia.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16421
 
+Value *PPCTargetLowering::getSDagStackGuard(const Module &M) const {
+  if (Subtarget.isAIXABI())
----------------
jsji wrote:
> jsji wrote:
> > hubert.reinterpretcast wrote:
> > > There's a number of instances of hard-coded `"__stack_chk_guard"` in what appears to be common code, e.g., in `llvm/lib/Transforms/IPO/Internalize.cpp`. I think those fall within the scope of this patch.
> > I think `InternalizePass` is not used by default pass builder. 
> > I can update it in a later patch if we really want to support it as well. 
> https://reviews.llvm.org/D103043 just landed so that it is easier to check triple now, I will create a follow up patch later (maybe after a few days when https://reviews.llvm.org/D103043 stabilized). @hubert.reinterpretcast 
`InternalizePass` is used by LTO afaik; @w2yehia, can you comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103100/new/

https://reviews.llvm.org/D103100