[PATCH] D103045: [flang] Implement checks for defined input/output procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/check-declarations.cpp:1040
   CheckSpecificsAreDistinguishable(symbol, details);
+  std::visit(common::visitors{
+                 [&](const GenericKind::DefinedIo &io) {
----------------
klausler wrote:
> Consider having one call to `CheckDefinedIoProc()` and using two `std::visit()` calls to calculate its last two arguments.
Good suggestion.  All of the information is actually inherent in the value of `GenericKind::DefinedIo`, so I can get everything I need by just passing `io` to `CheckDefinedIoProc()`.  That simplifies things a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103045/new/

https://reviews.llvm.org/D103045