[PATCH] D103045: [flang] Implement checks for defined input/output procedures

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

Looks really good; thanks for figuring all of this out from the standard.



================
Comment at: flang/lib/Semantics/check-declarations.cpp:1040
   CheckSpecificsAreDistinguishable(symbol, details);
+  std::visit(common::visitors{
+                 [&](const GenericKind::DefinedIo &io) {
----------------
Consider having one call to `CheckDefinedIoProc()` and using two `std::visit()` calls to calculate its last two arguments.


================
Comment at: flang/lib/Semantics/check-declarations.cpp:1760
+  }
+  return false;
+}
----------------
Should be nested in the `else`, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103045/new/

https://reviews.llvm.org/D103045