[PATCH] D103004: [llvm-mc] Add -M to replace -riscv-no-aliases and -riscv-arch-reg-names

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 07:38:36 PDT 2021


jrtc27 added a subscriber: craig.topper.
jrtc27 added a comment.

I think a mass purge of -(-)riscv-no-aliases is fine. I don't know why so many RVV CodeGen tests use it to be honest, it seems entirely unnecessary. @craig.topper / @frasercrmck is there a reason why the RVV CodeGen tests use --riscv-no-aliases everywhere? As far as I can tell there's nothing interesting hidden by aliases if I remove the option from all the RVV tests and regenerate them:

  waltham:llvm-project-upstream jrtc4% git diff | grep '^[-+]; CHECK' | sort | uniq -c
    24844 -; CHECK-NEXT:    jalr zero, 0(ra)
    24844 +; CHECK-NEXT:    ret
        8 -; CHECK-NEXT:    vl4re8.v v28, (a0)
        8 +; CHECK-NEXT:    vl4r.v v28, (a0)
       64 -; CHECK-NEXT:    vl8re8.v v24, (a0)
       64 +; CHECK-NEXT:    vl8r.v v24, (a0)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103004/new/

https://reviews.llvm.org/D103004



More information about the llvm-commits mailing list