[PATCH] D103004: [llvm-mc] Add -M to replace -riscv-no-aliases and -riscv-arch-reg-names

[Tomas Matheson via Phabricator via llvm-commits]

tmatheson added a comment.

If we are just keeping `-riscv-no-aliases` to avoid changing many tests it might be better to just remove it now. Otherwise it will likely stay forever. Maybe it is used externally though, I don't know.



================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:58
+  /// True if we prefer aliases (e.g. nop) to raw mnemonics.
+  bool PrintAliases = true;
+
----------------
It would be better if we could avoid ending up with two variables that mean essentially the same thing. I prefer the name `NoAliases` because it matches both command line flags better, and doesn't have the logical inversion that `PrintAliases` does. Can they both be made to use the same storage with `cl::location`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103004/new/

https://reviews.llvm.org/D103004