[PATCH] D103043: [Internalize] Rename instead of removal if a to-be-internalized comdat has more than one member

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 14:45:20 PDT 2021


xur added a comment.

I can understand the single member comdat part -- it should be safe to internalize it without break anything. I'm not sure I follow the rename part. Why can't the linker  handle the duplicated comdat? Is deduplication should be done by linker?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103043/new/

https://reviews.llvm.org/D103043



More information about the llvm-commits mailing list