[PATCH] D103043: [Internalize] Rename instead of removal if a to-be-internalized comdat has more than one member

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/Transforms/Internalize/comdat-empty-moduleid.ll:5
+
+;; Without an exported symbol, the module ID is empty. In this case we don't rename comdat for ELF.
+
----------------
tejohnson wrote:
> Presumably this doesn't hurt in practice because all of the internal symbols get removed during optimization?
Confirmed that GlobalOpt will discard all the internal symbols.

`opt -internalize a.ll | opt -O2 -S`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103043/new/

https://reviews.llvm.org/D103043