[PATCH] D102978: [WebAssembly] Add TargetInstrInfo::getCalleeOperand

Mon May 24 11:41:52 PDT 2021

aheejin added a comment.

In D102978#2777793 <https://reviews.llvm.org/D102978#2777793>, @dschuff wrote:

> I think this makes sense.
>
> my extra comment was that it seems likely that there are other places that currently use `getOperand(0)` that should now use this, and I was wondering if there were an easy way to find them since we can't just grep (especially since LLVM IR also has a getOperand). Thinking about that some more: Presumably uses in other backends would be safe to leave in place, and anything that affects codegen (at least in code that is covered at all) would be pretty broken, so maybe there actually aren't that many places outside of debug info (in other words broken debug info would be much more likely to go unnoticed than broken codegen).

I tried to search words like `CalleeOp` in the codebase but all other usages are in target-specific code, and there are only a few of them anyway. Also I think in other places it would have pretty much caused crashes anyway, so I'm not worried too much about it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102978/new/

https://reviews.llvm.org/D102978