[PATCH] D102978: [WebAssembly] Add TargetInstrInfo::getCalleeOperand
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 24 11:33:37 PDT 2021
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
I think this makes sense.
my extra comment was that it seems likely that there are other places that currently use `getOperand(0)` that should now use this, and I was wondering if there were an easy way to find them since we can't just grep (especially since LLVM IR also has a getOperand). Thinking about that some more: Presumably uses in other backends would be safe to leave in place, and anything that affects codegen (at least in code that is covered at all) would be pretty broken, so maybe there actually aren't that many places outside of debug info (in other words broken debug info would be much more likely to go unnoticed than broken codegen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102978/new/
https://reviews.llvm.org/D102978
More information about the llvm-commits
mailing list