[PATCH] D101819: [DRAFT][M68k GloballSel]Adding initial GlobalISel infrastructure
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 24 03:32:40 PDT 2021
RKSimon added a comment.
some minor style cleanups
================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:6
+tablegen(LLVM M68kGenRegisterInfo.inc -gen-register-info)
+tablegen(LLVM M68kGenRegisterBank.inc -gen-register-bank)
tablegen(LLVM M68kGenInstrInfo.inc -gen-instr-info)
----------------
(style) match indentation of the other entries
================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:21
M68kCollapseMOVEMPass.cpp
+ M68kCallLowering.cpp
M68kExpandPseudo.cpp
----------------
(style) sorting
================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:35
+ M68kLegalizerInfo.cpp
+ M68kRegisterBankInfo.cpp
----------------
(style) sorting
================
Comment at: llvm/lib/Target/M68k/M68k.h:22
class FunctionPass;
+class InstructionSelector;
class M68kTargetMachine;
----------------
(style) sorting
================
Comment at: llvm/lib/Target/M68k/M68kCallLowering.cpp:53
+}
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kCallLowering.h:45
+#endif // LLVM_LIB_TARGET_M68K_M68KCALLLOWERING_H
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kInstructionSelector.cpp:60
+} // end namespace llvm
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kLegalizerInfo.cpp:23
+}
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kLegalizerInfo.h:28
+#endif
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kRegisterBankInfo.cpp:27
+ : M68kGenRegisterBankInfo() {}
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kRegisterBankInfo.h:38
+#endif
\ No newline at end of file
----------------
(style) missing newline
================
Comment at: llvm/lib/Target/M68k/M68kRegisterBanks.td:14
+def GPRRegBank : RegisterBank<"AnyGPR", [DR8]>;
\ No newline at end of file
----------------
(style) missing newline
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101819/new/
https://reviews.llvm.org/D101819
More information about the llvm-commits
mailing list