[PATCH] D100944: [MC][ELF] Emit separate unique sections for different flags
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 20 17:57:03 PDT 2021
lhames added a comment.
In D100944#2759712 <https://reviews.llvm.org/D100944#2759712>, @tmatheson wrote:
> ...
> Changed Orc/RTDyldObjectLinkingLayerTest.cpp to use a non-allocatable
> section (.note.GNU-stack) for its check, rather than trying to place an
> object in the .debug_str section, which now results in a new .debug_str
> section with SHF_ALLOC.
I agree with @peter.smith's suggested changes to the debug logging strings ("debug" -> "non-alloc"). Otherwise the test case change looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100944/new/
https://reviews.llvm.org/D100944
More information about the llvm-commits
mailing list