[PATCH] D100944: [MC][ELF] Emit separate unique sections for different flags

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 15:16:25 PDT 2021


MaskRay added a comment.

This looks good to me as well. The `CHECK-LABEL:` conversion is unnecessary. I don't think it will improve diagnostics when things go off.
Logically ` .section .data,"aw", at progbits,unique,1` delimiter the regions. FileCheck then find labels in the regions.

If you use `-LABEL:`, FileCheck will find labels first. I think the resulting diagnostic is worse than using `CHECK:`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100944/new/

https://reviews.llvm.org/D100944



More information about the llvm-commits mailing list