[PATCH] D102764: [IR] Prefer not to delete blocks that have their address taken

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 11:36:32 PDT 2021


efriedma added a comment.

> Which is obviously no longer an address of a block, and iff the use semantically required it to actually be an address of a block, e.g. AArch64's S constaint in llvm/test/CodeGen/AArch64/inlineasm-S-constraint.ll, then the IR suddenly becomes invalid.

Not completely sure what you mean by "semantically required"; you mean it has to point somewhere in the same section?

We could add support for `blockaddress(@lower_blockaddress, null)` or something like that, I guess.  I don't think it makes sense to block the elimination of unreachable blocks; that's likely to cause other issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102764/new/

https://reviews.llvm.org/D102764



More information about the llvm-commits mailing list