[PATCH] D102764: [IR] Prefer not to delete blocks that have their address taken

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 06:39:49 PDT 2021


lebedev.ri added a comment.

In D102764#2768413 <https://reviews.llvm.org/D102764#2768413>, @jrtc27 wrote:

> My inclination is to say that address of should be treated the same as branching for BB liveness.

I'm not really sure how that would look.
It will, for sure, require LangRef changes, and somewhat invasive changes to the code.
Here i mostly only have enough motivation to avoid encountering/creating verifier errors,
not fixing the entirety of potentially-misdesigned `BlockAddress` thingy.

> Allow to delete unreachable that have their addresses taken - taking an address does not count as block reachability.

Though, i guess this isn't enough. We could still end up with a case
where AArch64's S constaint was expecting an address of a now-unreachable block.
So once again, i do not understand the rules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102764/new/

https://reviews.llvm.org/D102764



More information about the llvm-commits mailing list