[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

Marco Elver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 10:22:15 PDT 2021


melver added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
     if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
-        SanitizerMask())
+            SanitizerMask() &&
+        SanitizerName != "coverage")
----------------
aaron.ballman wrote:
> The formatting looks rather off here to my eyes, but if this is what clang-format produces for you, then I'm fine with it.
Yeah, I had something else here, but then clang-format suggested this and I don't like it either.

Could remove the /*AllowGroups=*/ bit, for the sake of formatting better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102772/new/

https://reviews.llvm.org/D102772



More information about the llvm-commits mailing list