[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 10:02:40 PDT 2021


aaron.ballman added a comment.

The clang parts look good to me, but someone else should do the final sign-off.



================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
     if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
-        SanitizerMask())
+            SanitizerMask() &&
+        SanitizerName != "coverage")
----------------
The formatting looks rather off here to my eyes, but if this is what clang-format produces for you, then I'm fine with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102772/new/

https://reviews.llvm.org/D102772



More information about the llvm-commits mailing list