[PATCH] D102686: [VP] getDeclarationForParams

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:393
+  // works for binary arithmetic VP intrinsics.
+  Value &FirstOp = *Params[0];
+  using ShortTypeVec = SmallVector<Type *, 1>;
----------------
craig.topper wrote:
> Is this written this way because of the TODO? It seems like this could just be
> 
> ```
> auto *VPFunc = Intrinsic::getDeclaration(M, VPID, Params[0]->getType());
> ```
> 
> Which avoids the SmallVector.
It's because of the todo.. other intrinsics will need multiple demangling types (eg `vp.fptosi`). No reason not to simplify it for now, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102686/new/

https://reviews.llvm.org/D102686