[PATCH] D101045: [IR][Verifier] Targets can specify multiple alloca address spaces
Andy Wingo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 19 02:13:05 PDT 2021
wingo marked an inline comment as done.
wingo added inline comments.
================
Comment at: llvm/docs/LangRef.rst:9574
currently executing function, to be automatically released when this
-function returns to its caller. The object is always allocated in the
-address space for allocas indicated in the datalayout.
----------------
arsenm wrote:
> I would rephrase this instead of dropping the statement altogether. Without target knowledge, any generic code introducing an alloca should be using the alloca address space in the datalayout
Thanks for feedback; updated. I was unsure how precisely to say "alloca outside the stack address space may be meaningless", given that this is the langref; thoughts welcome if there is a better way to say this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101045/new/
https://reviews.llvm.org/D101045
More information about the llvm-commits
mailing list