[PATCH] D102113: [MemCpyOpt] Remove MemDepAnalysis-based implementation
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 18 15:26:02 PDT 2021
asbirlea added a comment.
I believe the process is to additionally test a release after it's been cut, and potential issues that arise can be fixed and cherry-picked into that release. Flipping back the flag would probably not be a useful fix after 6+month, rather resolving the bug would be.
As an additional data point, we've had several internal releases since the flag was flipped and haven't encountered any issues. I'm not saying bugs are sure not to exist, just that there has been some fairly thorough testing done and I'd opt to fix forward rather than switch back to the MemDepAnalysis implementation.
If you have strong reasons to hold back another couple of month on this cleanup, that's an option too, I'm just outlining my reasoning for moving forward.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102113/new/
https://reviews.llvm.org/D102113
More information about the llvm-commits
mailing list