[PATCH] D102113: [MemCpyOpt] Remove MemDepAnalysis-based implementation

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D102113#2767036 <https://reviews.llvm.org/D102113#2767036>, @nikic wrote:

> In D102113#2764405 <https://reviews.llvm.org/D102113#2764405>, @fhahn wrote:
>
>> Did we change the default after the 12.0 branch? If so, it might be helpful to keep it until we branch for 13.0, so if users on 13.0 run into issue they can still fall back to the old version in the next release?
>
> I don't think this is a useful consideration. If there are issues, they need to be fixed on the release branch for everyone, not worked around by flipping a flag.

I agree, but sometimes that's not an option in practice, e.g. if the issue only pops up after the release. (also some vendors may not be able to ship point release quickly, so workarounds can be required in practice) 
It might be a bit over cautious, but from my experience it is quite common for issues to surface after a release is done. Given that the cost of keeping the code for the ~2 months until the next release branch seems low to me, I'd prefer to err on the side of caution. But I'm not holding that opinion strongly, so if removing the code now instead of in 2 month makes things noticeably easier that's fine by me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102113/new/

https://reviews.llvm.org/D102113