[PATCH] D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:409
+  Value *getMemoryPointerParam() const;
+  static Optional<int> GetMemoryPointerParamPos(Intrinsic::ID);
+
----------------
Should this be getMemoryPointerParamPos as clang-format says?


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:413
+  Value *getMemoryDataParam() const;
+  static Optional<int> GetMemoryDataParamPos(Intrinsic::ID);
+
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99355/new/

https://reviews.llvm.org/D99355