[PATCH] D102253: [LV] Prevent vectorization with unsupported element types.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1515
 
+  bool canVectorizeInstructionTypes(ElementCount VF) {
+    for (BasicBlock *BB : TheLoop->blocks())
----------------
david-arm wrote:
> nit: Could you add a simple comment above the function before committing? Something like
> 
>   /// Returns true if all types found in the loop are legal to vectorize.
> 
> maybe?
I think terminology used in other places is 'widening' instead of 'vectorizing' , both in the cost model and codegen. Does vectorizing here means something different? Also would be good to add a comment for the function..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102253/new/

https://reviews.llvm.org/D102253