[PATCH] D102253: [LV] Prevent vectorization with unsupported element types.

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for dealing with review comments!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1515
 
+  bool canVectorizeInstructionTypes(ElementCount VF) {
+    for (BasicBlock *BB : TheLoop->blocks())
----------------
nit: Could you add a simple comment above the function before committing? Something like

  /// Returns true if all types found in the loop are legal to vectorize.

maybe?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-illegal-type.ll:1
+; RUN: opt < %s -loop-vectorize -force-target-supports-scalable-vectors=true -force-vector-width=4 -pass-remarks-analysis=loop-vectorize -S 2>%t | FileCheck %s
+; RUN: cat %t | FileCheck %s -check-prefix=CHECK-REMARKS
----------------
nit: Since this test is now in the AArch64 directory I think you can replace "-force-target-supports.." with "-mattr=+sve"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102253/new/

https://reviews.llvm.org/D102253