[PATCH] D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE

[David Truby via Phabricator via llvm-commits]

DavidTruby added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:231-232
+    // For fixed vectors, avoid scalarization if using SVE for them.
+    if (isa<FixedVectorType>(DataType) && !ST->useSVEForFixedLengthVectors())
+      return false; // Fall back to scalarization of masked operations.
+
----------------
kmclaughlin wrote:
> nit: is it maybe worth merging this with the `if (!ST->hasSVE())` condition above?
I kept these conditions separate because they're logically different and the if statement gets difficult to grok in my opinion if they're combined


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101834/new/

https://reviews.llvm.org/D101834