[PATCH] D102385: [GlobalISel][IRTranslator] Use preferred alignment when creating frame indices.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:535
+  /// alignment.
+  virtual bool shouldGISelOverAlignAllocas() const {
+    return false;
----------------
arsenm wrote:
> I really don't like this hook. We have way too many super specific hacky hooks like this. Is this really a concern? Why isn't the frontend setting the preferred alignment to begin with?
>  in practice frontends emit them with the preferred alignment to begin with.

I can't find where this is happening. I'm too familiar with clang but if I grep for 'getPrefTypeAlign' I only see a few places where it's called there, which look specific to some cases, not general allocas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102385/new/

https://reviews.llvm.org/D102385