[PATCH] D102385: [GlobalISel][IRTranslator] Use preferred alignment when creating frame indices.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 06:31:35 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:535
+  /// alignment.
+  virtual bool shouldGISelOverAlignAllocas() const {
+    return false;
----------------
I really don't like this hook. We have way too many super specific hacky hooks like this. Is this really a concern? Why isn't the frontend setting the preferred alignment to begin with?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102385/new/

https://reviews.llvm.org/D102385



More information about the llvm-commits mailing list