[PATCH] D102619: [lld/mac] Set REFERENCED_DYAMICALLY on __mh_execute_header

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 07:26:45 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:445
+  // we'll have to add an `isReferencedDynamically` arg to Defined's
+  // constructor and pass this in.
+  assert(!(sym.n_desc & REFERENCED_DYNAMICALLY));
----------------
Turns out this isn't true, and http://llvm-cs.pcc.me.uk/lib/Support/PrettyStackTrace.cpp#121 does trigger this assert. I'll update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102619/new/

https://reviews.llvm.org/D102619



More information about the llvm-commits mailing list