[PATCH] D102515: [CostModel] Return an invalid cost for memory ops with unsupported types

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for adding the test!



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1164
+
+  VectorType *VTy = dyn_cast<VectorType>(Src);
+  if (VTy && !isLegalToVectorizeElementType(
----------------
nit: I think because we bail out at the start of the function if it's not a scalable vector we can actually just do:

  VectorType *VTy = cast<ScalableVectorType>(Src);
  if (!isLegalToVectorizeElementType(...))

This is also true for getGatherScatterOpCost


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102515/new/

https://reviews.llvm.org/D102515