[PATCH] D102515: [CostModel] Return an invalid cost for memory ops with unsupported types

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 06:53:27 PDT 2021


kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:998
       if (VT.getVectorElementCount() == ElementCount::getScalable(1))
-        report_fatal_error("Cannot legalize this scalable vector");
+        return LegalizeKind(TypeScalarizeScalableVector, EltVT);
       return LegalizeKind(TypeSplitVector,
----------------
david-arm wrote:
> Hi @kmclaughlin is it possible to add a test for this? For example, just another test for <vscale x 1 x i128>.
Hi @david-arm, I've changed the `@store_nxvi128` test to use `vscale x 1 x i128`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102515/new/

https://reviews.llvm.org/D102515



More information about the llvm-commits mailing list