[PATCH] D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 01:05:42 PDT 2021


ChuanqiXu added a comment.

In D102594#2762590 <https://reviews.llvm.org/D102594#2762590>, @mdchen wrote:

> In D102594#2762526 <https://reviews.llvm.org/D102594#2762526>, @ChuanqiXu wrote:
>
>> 
>
>
>
>> And I am wondering the reason you want to define DEBUG_TYPE in a header file. It isn't what we used to do.
>
> I don't think it's true. We can find many header files under llvm/include/ have their own `DEBUG_TYPE`, and it works well if you carefully undefine it at the end of the file.

Yeah, the codes shows you are right. I find definitions for `DEBUG_TYPE` in some headers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102594/new/

https://reviews.llvm.org/D102594



More information about the llvm-commits mailing list