[PATCH] D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 00:37:07 PDT 2021


mdchen added a comment.

In D102594#2762526 <https://reviews.llvm.org/D102594#2762526>, @ChuanqiXu wrote:

> 



> And I am wondering the reason you want to define DEBUG_TYPE in a header file. It isn't what we used to do.

I don't think it's true. We can find many header files under llvm/include/ have their own `DEBUG_TYPE`, and it works well if you carefully undefine it at the end of the file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102594/new/

https://reviews.llvm.org/D102594



More information about the llvm-commits mailing list