[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D85774#2760205 <https://reviews.llvm.org/D85774#2760205>, @jasonliu wrote:

> In D85774#2758956 <https://reviews.llvm.org/D85774#2758956>, @jhenderson wrote:
>
>> I took a quick look at the pre-merge output. The message is that the object isn't recognised as a valid object file, not that it wasn't found, which suggests either the object or code is broken in some manner, or you're missing a dependent patch. Does this patch depend on another patch that isn't in main yet?
>
> No this patch does not depend on other patches. I think this is caused by git generated binary for the patch doesn't really assemble to the same one?

Sounds vaguely plausible, I guess.



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-aux-wrong64.test:1-2
+## This file tests the raw data output ability when file auxiliary
+##  entry do not have the matching auxiliary type.
+
----------------
Fix a couple of grammar issues and a premature line-wrap.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-aux-wrong64.test:4-5
+
+# RUN: llvm-readobj --symbols %p/Inputs/file-aux-wrong64.o | \
+# RUN: FileCheck %s
+
----------------



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-aux-wrong64.test:19
+# CHECK-NEXT:     612e7300 00000000 00000000 00000000
+# CHECK-NEXT: 00fb  }
+# CHECK-NEXT: ]
----------------
The output on this line looks incorrect to me. Possibly a bug in the code resulting from a missing newe line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774