[PATCH] D102588: [UpdateTestChecks] Default --x86_scrub_rip to False

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 16 15:28:53 PDT 2021


MaskRay created this revision.
MaskRay added reviewers: craig.topper, hvdijk, RKSimon, pengfei, spatel.
Herald added subscribers: StephenFan, arichardson.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

True is a bad default: the useful symbol names and `@GOTPCREL` are scrubbed.

Change the default and add global variable tests to x86-basic.ll
(renamed from x86_function_name.ll since we now also test variables).
I updated some tests to show the differences.

Updated LCPI regex to include Darwin style `LCPI_[0-9]+_[0-9]+` (no
leading dot).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102588

Files:
  llvm/test/CodeGen/X86/2009-03-23-MultiUseSched.ll
  llvm/test/CodeGen/X86/WidenArith.ll
  llvm/test/CodeGen/X86/abi-isel.ll
  llvm/test/CodeGen/X86/xor.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll.expected
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll.expected
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-basic.test
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-function-name.test
  llvm/utils/UpdateTestChecks/asm.py
  llvm/utils/update_llc_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102588.345731.patch
Type: text/x-patch
Size: 251791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210516/6a76f0d1/attachment-0001.bin>


More information about the llvm-commits mailing list