[PATCH] D102296: [ELF] getRelocatedSection should work for executables with --emit-relocs

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 16 14:46:34 PDT 2021


MaskRay added a comment.

Please add tests for such functional changes.

The subject line is usually an imperative sentence. Mention what the patch changes, instead of stating a fact that people agree with (it is unclear what you do in the patch to fulfill the goal)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102296/new/

https://reviews.llvm.org/D102296



More information about the llvm-commits mailing list