[PATCH] D102201: [IR][AutoUpgrade] Drop align attribute from void return types

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I can see how this increases IR size but I'm not sure about binary size. If you have your IR in the binary, then that is probably it. If not, I would assume it's some secondary effect that should not exist.

FWIW, IR size increase:

  declare align 8 void @f() willreturn;
  declare align 8 int *@g() willreturn;

share the same attribute set but if you remove align 8 from @f we have two distinct attribute sets in the IR.

---

I would not revert D87304 <https://reviews.llvm.org/D87304> and this one to undo the binary size increase. Both patches fix assertions that can hit in practice.
We need to understand what caused the increase and target that part. Allowing `align X void` on returns is not a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102201/new/

https://reviews.llvm.org/D102201