[PATCH] D102201: [IR][AutoUpgrade] Drop align attribute from void return types

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D102201#2761403 <https://reviews.llvm.org/D102201#2761403>, @dexonsmith wrote:

> In D102201#2761154 <https://reviews.llvm.org/D102201#2761154>, @thakis wrote:
>
>> We bisected a +153kB binary size increase for chrome/android to this (https://bugs.chromium.org/p/chromium/issues/detail?id=1208513#c4). Is that expected? (That build config uses -Oz for many TUs.)
>
> Hmm, that seems pretty weird — this commit fixes a compiler crash introduced by a missing bitcode upgrade from https://reviews.llvm.org/D87304, they should be reverted together if we need to revert something.
>
> @jdoerfert, any thoughts on why removing the `align` attribute causes a regression here?
>
> @thakis, is it possible the Chromium build is skipping the bitcode verifier when reading bitcode?

As far as I can tell we don't do anything clever in this area. We build clang without assertions and then use -flto=thin. What would cause clang to skip the bitcode verifier?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102201/new/

https://reviews.llvm.org/D102201