[PATCH] D102486: Use a non-recursive mutex in GsymCreator.
Simon Giesecke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 15 02:41:56 PDT 2021
simon.giesecke added a comment.
In D102486#2760645 <https://reviews.llvm.org/D102486#2760645>, @grandinj wrote:
> In D102486#2759417 <https://reviews.llvm.org/D102486#2759417>, @simon.giesecke wrote:
>
>> GSYM conversion still spends a significant time for locking in `GsymCreator::insertString` even with only 8 threads, so lock contention seems to be generally an issue
>
> Could perhaps start by moving the CachedHashStringRef construction outside the lock?
Yes, makes sense. I have missed that opportunity somehow in D102484 <https://reviews.llvm.org/D102484>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102486/new/
https://reviews.llvm.org/D102486
More information about the llvm-commits
mailing list