[PATCH] D102486: Use a non-recursive mutex in GsymCreator.

[Greg Clayton via Phabricator via llvm-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

In D102486#2759417 <https://reviews.llvm.org/D102486#2759417>, @simon.giesecke wrote:

> GSYM conversion still spends a significant time for locking in `GsymCreator::insertString` even with only 8 threads, so lock contention seems to be generally an issue here. I was wondering if we could avoid locking the mutex here, but using thread-local tables until finalisation does not seem to be feasible since any thread might insert the same string IIUC and we want to have unique IDs at this point. A lock-free map might be an alternative here, though?

I am open to ideas to speed things up, but many things rely on strings being correctly uniqued: strings for function names and inlined function names, files in the file tables (which consist of two string: directory + basename).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102486/new/

https://reviews.llvm.org/D102486