[PATCH] D102316: [symbolizer] Added StartAddress for the resolved function.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D102316#2760395 <https://reviews.llvm.org/D102316#2760395>, @aorlov wrote:

> Of course I though about multiple ranges case. And preferred keeping it simple for the beginning. This patch does not print `StartAddress` if DW_AT_low_pc is missing. That’s the case #1 in the above list of options. As already mentioned, in case of multiple ranges we do not know for sure where a function starts, at least not without an extra analyses of the code. We will need more solid use case and samples to move to that direction. Not a subject of this patch.
>
> To summarize.
>
> 1. I will add `StartAddress` to the verbose output for LLVM.
> 2. If/when time permits I’ll follow up with gnu community with the proposal pointing to LLVM output as an example.
>
> The patch is coming shortly.
>
> By the way, llvm-symbolizer always uses symbol table. `Opts.UseSymbolTable = true` is hard coded and user has no way to control that.

Fair enough.

(re: symbol table - I meant for figuring out the address - I think the "UseSymbolTable" is for the names, not the addresses (see the comments in SymbolizableObjectFile::shouldOverrideWithSymbolTable))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102316/new/

https://reviews.llvm.org/D102316