[llvm] 4464250 - [NFC][llvm-dwarfdump] Avoid passing std::string by value in collectStatsForDie()

Djordje Todorovic via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 01:30:18 PDT 2021


Author: Djordje Todorovic
Date: 2021-05-12T01:29:37-07:00
New Revision: 44642505ce6be476124575f1589552bd53a6fdeb

URL: https://github.com/llvm/llvm-project/commit/44642505ce6be476124575f1589552bd53a6fdeb
DIFF: https://github.com/llvm/llvm-project/commit/44642505ce6be476124575f1589552bd53a6fdeb.diff

LOG: [NFC][llvm-dwarfdump] Avoid passing std::string by value in collectStatsForDie()

Added: 
    

Modified: 
    llvm/tools/llvm-dwarfdump/Statistics.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-dwarfdump/Statistics.cpp b/llvm/tools/llvm-dwarfdump/Statistics.cpp
index 48e6610f765d9..19a971afa3111 100644
--- a/llvm/tools/llvm-dwarfdump/Statistics.cpp
+++ b/llvm/tools/llvm-dwarfdump/Statistics.cpp
@@ -220,9 +220,9 @@ static uint64_t calculateOverlap(DWARFAddressRange A, DWARFAddressRange B) {
 }
 
 /// Collect debug info quality metrics for one DIE.
-static void collectStatsForDie(DWARFDie Die, std::string FnPrefix,
-                               std::string VarPrefix, uint64_t BytesInScope,
-                               uint32_t InlineDepth,
+static void collectStatsForDie(DWARFDie Die, const std::string &FnPrefix,
+                               const std::string &VarPrefix,
+                               uint64_t BytesInScope, uint32_t InlineDepth,
                                StringMap<PerFunctionStats> &FnStatMap,
                                GlobalStats &GlobalStats,
                                LocationStats &LocStats,


        


More information about the llvm-commits mailing list