[PATCH] D102136: [NewPM] Add C bindings for new pass manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 10:52:41 PDT 2021


aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderBindings.cpp:35
+  bool VerifyEach;
+  PipelineTuningOptions *PTO;
+};
----------------
can we just make this `PipelineTuningOptions PTO`? no need for a separate PTO instance. it makes the API more complicated than necessary (for example if someone just wants the default settings)
and we can just pass LLVMPassBuilderOptionsRef to the PTO APIs instead of exposing LLVMPipelineTuningOptionsRef


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102136/new/

https://reviews.llvm.org/D102136



More information about the llvm-commits mailing list