[PATCH] D102136: [NewPM] Add C bindings for new pass manager
Mats Larsen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 13 16:35:22 PDT 2021
supergrecko added a comment.
In D102136#2757551 <https://reviews.llvm.org/D102136#2757551>, @aeubanks wrote:
> looks pretty good, just one nit
Good point. I have updated LLVMRunPasses to accept an LLVMPassBuilderOptionsRef which is currently a triplet of VerifyEach, DebugLogging and PipelineTuningOptions. I've made the construction/destruction/modification of this struct on the C-side equal to PipelineTuningOptions.
The llvm::LLVMPassBuilderOptions class is kept private to the bindings source because there shouldn't be a reason for anybody else to use this class. Right now I am using an assert for the LLVMPassBuilderOptionsRef->PTO to be present, but we could also change this to an LLVMErrorRef if that's preferable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102136/new/
https://reviews.llvm.org/D102136
More information about the llvm-commits
mailing list