[PATCH] D101847: [AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass.

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:252
         CallBase *CI = dyn_cast<CallBase>(I);
-        if (!CI)
+        if (!CI || CI->getCalledOperand() != &F)
           continue;
----------------
A comment here, please!


================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-attributes-function-pointer-argument.ll:14
+; CHECK: define amdgpu_kernel void @thiswasabug() #0
+; CHECK: call void @f(void ()* @g.1)
+; CHECK: call void @g()
----------------
madhur13490 wrote:
> Probably can have CHECK-NOT too to explicitly call out what should not be generated.
CHECK-LABEL followed by CHECK-DAG would be more appropriate here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101847/new/

https://reviews.llvm.org/D101847