[PATCH] D101847: [AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass.

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added a comment.

In D101847#2755717 <https://reviews.llvm.org/D101847#2755717>, @arsenm wrote:

> I think at this point I'd prefer to just not worry about the cast stripping case and go back to just handling the direct callee.
>
> This pass should not be required for correctness, and is only because opencl is still not linking the device libraries correctly such that the linked in functions have the correct subtarget/subtarget features. Long term I would like to move this pass into a form that does conservative merges of attributes, which can safely give up on anything indirect looking

I think the new diff can be kept as anyway you have spent effort on it. But I am fine either way.



================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-attributes-function-pointer-argument.ll:14
+; CHECK: define amdgpu_kernel void @thiswasabug() #0
+; CHECK: call void @f(void ()* @g.1)
+; CHECK: call void @g()
----------------
Probably can have CHECK-NOT too to explicitly call out what should not be generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101847/new/

https://reviews.llvm.org/D101847