[PATCH] D101938: [RISCV] Initial version of a demand based vsetvli insertion pass.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM, good stuff. One minor nit and a question.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:235
+
+    if (PrevVSETVLI && (MI.isCall() || MI.modifiesRegister(RISCV::VL) ||
+                        MI.modifiesRegister(RISCV::VTYPE))) {
----------------
Not for this patch but should we make sure calls are marked as clobbering VL/VTYPE? Or is there a reason to keep them separate?


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:251
+
+  const RISCVSubtarget &Subtarget = MF.getSubtarget<RISCVSubtarget>();
+  TII = Subtarget.getInstrInfo();
----------------
`ST` has already been defined above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101938/new/

https://reviews.llvm.org/D101938